Open
Conversation
add a condition to check what architecture we will be executing Helm (arm64 or amd64). This will ensure that we download the correct binaries for that platform. Currently, on a arm64 Mac (M1/M2 processors) we are downloading the amd64 helm binary and are using Rosetta for the translation. This breaks on any other OS (e.g.: Linux) running on aarch64. this is a WIP as the https://k8connecthelm.azureedge.net/helm/ only contains the amd64 version of helm.
Collaborator
|
connectedk8s adds support for arm64 |
|
Any update on this? (friendly ping @yonzhan) Note: a workaround is possible by creating a symlink to the correct HELM binaries |
Contributor
|
@akashkeshari Could you please help review the connectedk8s extension related PR? |
Contributor
|
@akashkeshari CLI will support ARM64 in 2.46.0. Related PR: Azure/azure-cli#24180 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add a condition to check what architecture we will be executing Helm (arm64 or amd64). This will ensure that we download the correct binaries for that platform. Currently, on a arm64 Mac (M1/M2 processors) we are downloading the amd64 helm binary and are using Rosetta for the translation. This breaks on any other OS (e.g.: Linux) running on aarch64.
this is a WIP as the https://k8connecthelm.azureedge.net/helm/ only contains the amd64 version of helm.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify
src/index.json.